]> asedeno.scripts.mit.edu Git - linux.git/commit
drm/amdgpu: Fix bounds checking in amdgpu_ras_is_supported()
authorDan Carpenter <dan.carpenter@oracle.com>
Sat, 8 Jun 2019 09:23:57 +0000 (12:23 +0300)
committerAlex Deucher <alexander.deucher@amd.com>
Thu, 13 Jun 2019 01:39:48 +0000 (20:39 -0500)
commit99f304beb82a86713dc4bc1fd65b8dfda25b1f5e
treeac015e389c4cc3d91bf0d4efcb57ac41f69f3d55
parent517b91f4cde3043d77b2178548473e8545ef07cb
drm/amdgpu: Fix bounds checking in amdgpu_ras_is_supported()

The "block" variable can be set by the user through debugfs, so it can
be quite large which leads to shift wrapping here.  This means we report
a "block" as supported when it's not, and that leads to array overflows
later on.

This bug is not really a security issue in real life, because debugfs is
generally root only.

Fixes: 36ea1bd2d084 ("drm/amdgpu: add debugfs ctrl node")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.h