]> asedeno.scripts.mit.edu Git - linux.git/commit
iwlwifi: pcie: Fail fast if HW is inaccessible at probe
authorRajat Jain <rajatja@google.com>
Fri, 27 Apr 2018 00:43:50 +0000 (17:43 -0700)
committerLuca Coelho <luciano.coelho@intel.com>
Fri, 28 Sep 2018 05:57:26 +0000 (08:57 +0300)
commit9a098a89df79e4cc5e743d7d4acf42bdbcc32ee7
tree9fbae686783cc09c1e440c47030560d0cb696dc8
parentbb03927e0eafef4d2509ff3df7550acf98efea97
iwlwifi: pcie: Fail fast if HW is inaccessible at probe

If the HW is not responding at probe time, fail immediately complaining
about it. Without this, we see that the kernel spends > 100ms trying to
load firmware (even gives an incorrect impression that it actually
loaded a firmware) and do unnecesary processing before concluding that
the device is not accessible:

 INFO kernel: [   34.092678] iwlwifi 0000:01:00.0: enabling device (0000 -> 0002)
 WARNING kernel: [   34.093560] iwlwifi 0000:01:00.0: Direct firmware load for iwl-dbg-cfg.ini failed with error -2
 INFO kernel: [   34.111523] iwlwifi 0000:01:00.0: loaded firmware version 17.318154.0 op_mode iwlmvm
 INFO kernel: [   34.173250] iwlwifi 0000:01:00.0: Detected Intel(R) Dual Band Wireless AC 7265, REV=0xFFFFFFFF
 ERR kernel: [   34.198023] iwlwifi 0000:01:00.0: iwlwifi transaction failed, dumping registers
 ERR kernel: [   34.198044] iwlwifi 0000:01:00.0: iwlwifi device config registers:

Signed-off-by: Rajat Jain <rajatja@google.com>
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
drivers/net/wireless/intel/iwlwifi/pcie/trans.c