]> asedeno.scripts.mit.edu Git - linux.git/commit
net: phy: Restore phy_resume() locking assumption
authorAndrew Lunn <andrew@lunn.ch>
Tue, 27 Feb 2018 00:56:06 +0000 (01:56 +0100)
committerDavid S. Miller <davem@davemloft.net>
Tue, 27 Feb 2018 19:32:09 +0000 (14:32 -0500)
commit9c2c2e62df3fa30fb13fbeb7512a4eede729383b
tree172262c56d18345b4e762f4361f75c5bcbadc483
parent1b22bcad7e397252ecc9a8c471334f70b46820fc
net: phy: Restore phy_resume() locking assumption

commit f5e64032a799 ("net: phy: fix resume handling") changes the
locking semantics for phy_resume() such that the caller now needs to
hold the phy mutex. Not all call sites were adopted to this new
semantic, resulting in warnings from the added
WARN_ON(!mutex_is_locked(&phydev->lock)).  Rather than change the
semantics, add a __phy_resume() and restore the old behavior of
phy_resume().

Reported-by: Heiner Kallweit <hkallweit1@gmail.com>
Fixes: f5e64032a799 ("net: phy: fix resume handling")
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/phy/phy.c
drivers/net/phy/phy_device.c
include/linux/phy.h