]> asedeno.scripts.mit.edu Git - linux.git/commit
ARM: OMAP2+: gpmc: Fix writing in gpmc_cs_set_memconf
authorSemen Protsenko <semen.protsenko@globallogic.com>
Sat, 24 Jan 2015 20:28:38 +0000 (22:28 +0200)
committerRoger Quadros <rogerq@ti.com>
Wed, 25 Feb 2015 10:47:32 +0000 (12:47 +0200)
commit9c4f757ee9c64623efec61672305f87452f68968
tree4c8c85adad625fc62fa7f3c0bc420a2c9a78c137
parentc517d838eb7d07bbe9507871fab3931deccff539
ARM: OMAP2+: gpmc: Fix writing in gpmc_cs_set_memconf

Some GPMC_CONFIG7 register bits marked as "RESERVED", means they
shouldn't be overwritten. A typical approach to handle such bits called
"Read-Modify-Write". Writing procedure used in gpmc_cs_set_memconf()
utilizes RMW technique, but implemented incorrectly. Due to obvious typo
in code read register value is being rewritten by another value, which
leads to loss of read RESERVED bits. This patch fixes this.

While at it, replace magic numbers with named constants to improve code
readability.

Signed-off-by: Semen Protsenko <semen.protsenko@globallogic.com>
Acked-by: Tony Lindgren <tony@atomide.com>
Signed-off-by: Roger Quadros <rogerq@ti.com>
drivers/memory/omap-gpmc.c