]> asedeno.scripts.mit.edu Git - linux.git/commit
media: uvcvideo: Avoid NULL pointer dereference at the end of streaming
authorSakari Ailus <sakari.ailus@linux.intel.com>
Wed, 30 Jan 2019 10:09:41 +0000 (05:09 -0500)
committerMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Thu, 7 Feb 2019 16:55:49 +0000 (11:55 -0500)
commit9dd0627d8d62a7ddb001a75f63942d92b5336561
tree6231a95fdcfb3d9ab974bf33196362182ec5965f
parent47bb117911b051bbc90764a8bff96543cbd2005f
media: uvcvideo: Avoid NULL pointer dereference at the end of streaming

The UVC video driver converts the timestamp from hardware specific unit
to one known by the kernel at the time when the buffer is dequeued. This
is fine in general, but the streamoff operation consists of the
following steps (among other things):

1. uvc_video_clock_cleanup --- the hardware clock sample array is
   released and the pointer to the array is set to NULL,

2. buffers in active state are returned to the user and

3. buf_finish callback is called on buffers that are prepared.
   buf_finish includes calling uvc_video_clock_update that accesses the
   hardware clock sample array.

The above is serialised by a queue specific mutex. Address the problem
by skipping the clock conversion if the hardware clock sample array is
already released.

Fixes: 9c0863b1cc48 ("[media] vb2: call buf_finish from __queue_cancel")
Reported-by: Chiranjeevi Rapolu <chiranjeevi.rapolu@intel.com>
Tested-by: Chiranjeevi Rapolu <chiranjeevi.rapolu@intel.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: stable@vger.kernel.org
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
drivers/media/usb/uvc/uvc_video.c