]> asedeno.scripts.mit.edu Git - linux.git/commit
perf tools: Remove newline char when reading event scale and unit
authorMadhavan Srinivasan <maddy@linux.vnet.ibm.com>
Sun, 31 May 2015 06:06:23 +0000 (11:36 +0530)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Mon, 1 Jun 2015 13:26:19 +0000 (10:26 -0300)
commit9ecae065f3295d7ea5e1c5492170a848ca255a46
tree38c065c7e2a71a4cb101796b4af48bdff5436095
parent6bb536cc4b06df70012cec6168cc1788e200bc9d
perf tools: Remove newline char when reading event scale and unit

The <fd979c013207> commit intruduced the perf_event_sysfs_show function
to display the event_str value of an attr in kernel/event/core.c. But
the function returns the value with a newline char.

So, if a event also carries a event.unit file, when printing the counter
data perf tool formatting goes for a spin.

That is, because of the event unit, event name is printed in the newline
because of perf_event_sysfs_show returns with a newline char.

Now fixing perf core will break API, hencing proposing a fix in the perf tool.

Signed-off-by: Madhavan Srinivasan <maddy@linux.vnet.ibm.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
Link: http://lkml.kernel.org/r/1433052383-21802-1-git-send-email-maddy@linux.vnet.ibm.com
[ Add spaces around operators ]
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/util/pmu.c