]> asedeno.scripts.mit.edu Git - linux.git/commit
ASoC: sh/fsi: Make one-bit bitfields unsigned
authorLars-Peter Clausen <lars@metafoo.de>
Thu, 19 Jun 2014 07:40:31 +0000 (09:40 +0200)
committerMark Brown <broonie@linaro.org>
Sat, 21 Jun 2014 20:02:08 +0000 (21:02 +0100)
commit9f98cd69c1517e05aa00ab843f054457cc3488c1
treebb93d93058573185afec5723158a7d895b0ffcf7
parent7171511eaec5bf23fb06078f59784a3a0626b38f
ASoC: sh/fsi: Make one-bit bitfields unsigned

One-bit signed bitfields have two possible values: 0 and -1. This sometimes
leads to unexpected results (e.g. foo.bar = 1; foo.bar == 1 => false) which is
why it is recommended to make one-bit bitfields unsigned.

This fixes the following sparse warnings:
sound/soc/sh/fsi.c:267:25: error: dubious one-bit signed bitfield
sound/soc/sh/fsi.c:268:22: error: dubious one-bit signed bitfield
sound/soc/sh/fsi.c:269:20: error: dubious one-bit signed bitfield
sound/soc/sh/fsi.c:270:28: error: dubious one-bit signed bitfield
sound/soc/sh/fsi.c:271:26: error: dubious one-bit signed bitfield
sound/soc/sh/fsi.c:272:25: error: dubious one-bit signed bitfield

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: Mark Brown <broonie@linaro.org>
sound/soc/sh/fsi.c