]> asedeno.scripts.mit.edu Git - linux.git/commit
net: hns3: fix improper error handling in the hclge_init_ae_dev()
authorHuazhong Tan <tanhuazhong@huawei.com>
Wed, 30 Jan 2019 20:55:49 +0000 (04:55 +0800)
committerDavid S. Miller <davem@davemloft.net>
Wed, 30 Jan 2019 22:50:03 +0000 (14:50 -0800)
commit9fc55413270fffe1b5ebdea03489d763c62c0305
tree63922ea0269f35ad1dbb860011682cb5a6cddd08
parent472d7ecee20e8fea18e6223cc1d383b6c3483502
net: hns3: fix improper error handling in the hclge_init_ae_dev()

While hclge_init_umv_space() failed in the hclge_init_ae_dev(),
we should undo all the operation which has been done successfully,
the last success operation maybe hclge_mac_mdio_config(), so if
hclge_init_umv_space() failed, we also need to undo it.

Fixes: 288475b2ad01 ("{topost} net: hns3: refine umv space allocation")
Signed-off-by: Huazhong Tan <tanhuazhong@huawei.com>
Signed-off-by: Peng Li <lipeng321@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c