]> asedeno.scripts.mit.edu Git - linux.git/commit
drm/i915: Remove unneeded disconnect in TypeC legacy port mode
authorImre Deak <imre.deak@intel.com>
Fri, 28 Jun 2019 14:36:34 +0000 (17:36 +0300)
committerImre Deak <imre.deak@intel.com>
Mon, 1 Jul 2019 12:06:32 +0000 (15:06 +0300)
commita171f8e7f466345a2a0c7bacdc7992777e1c1f37
tree99ce304bdac23d4e21378e41718d1785a7972a56
parentd5ce34da31456a28fb2c35db0d0f57b7e4af477e
drm/i915: Remove unneeded disconnect in TypeC legacy port mode

Disconnecting the TypeC PHY when the port is in legacy mode is not
necessary:
- BSpec doesn't specify a disconnect sequence for legacy mode.
- The use of the PHY is dedicated for the display in legacy mode.
- We keep the PHY always connected during runtime as well in legacy
  mode.

We disconnect the PHY when needed during a disabling modeset for the
port, so we can also remove the disconnect call from the destroy hook.

Cc: José Roberto de Souza <jose.souza@intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: Imre Deak <imre.deak@intel.com>
Reviewed-by: José Roberto de Souza <jose.souza@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190628143635.22066-23-imre.deak@intel.com
drivers/gpu/drm/i915/display/intel_ddi.c
drivers/gpu/drm/i915/display/intel_tc.c
drivers/gpu/drm/i915/display/intel_tc.h