]> asedeno.scripts.mit.edu Git - linux.git/commit
drm/msm: avoid false-positive -Wmaybe-uninitialized warning
authorArnd Bergmann <arnd@arndb.de>
Mon, 4 Dec 2017 14:44:23 +0000 (15:44 +0100)
committerRob Clark <robdclark@gmail.com>
Wed, 13 Dec 2017 16:11:55 +0000 (11:11 -0500)
commita1ed6def4410451eeb2ce85b4270e6fe9d3c902c
treec014e2307eaa51c132ec72466009980c6fbcea1f
parent8dcbde0f230594eada5646191bdb4a29be1876f6
drm/msm: avoid false-positive -Wmaybe-uninitialized warning

gcc-8 -fsanitize-coverage=trace-pc produces a false-positive warning:

drivers/gpu/drm/msm/mdp/mdp5/mdp5_plane.c: In function 'mdp5_plane_mode_set.isra.8':
drivers/gpu/drm/msm/mdp/mdp5/mdp5_plane.c:1053:3: error: 'crtc_x_r' may be used uninitialized in this function [-Werror=maybe-uninitialized]

It's relatively clear from reading the source that this cannot happen,
and older compilers get it right. This rearranges the code remove
the two affected variables, which reliably avoids the problem.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Rob Clark <robdclark@gmail.com>
drivers/gpu/drm/msm/mdp/mdp5/mdp5_plane.c