]> asedeno.scripts.mit.edu Git - linux.git/commit
serial: 8250_of: Fix for lack of interrupt support
authorJohn Garry <john.garry@huawei.com>
Thu, 30 Aug 2018 09:08:50 +0000 (17:08 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 18 Sep 2018 14:07:25 +0000 (16:07 +0200)
commita27d938251ef40c43db81af16fc26b2cec181d4d
tree541b488cb94874fd05ab91e11b54b4bc32df566b
parentc362272bdea32bf048d6916b0a2dc485eb9cf787
serial: 8250_of: Fix for lack of interrupt support

In commit c58caaab3bf8 ("serial: 8250: of: Defer probe on missing IRQ"), a
check was added for the UART driver being probed prior to the parent IRQ
controller.

Unfortunately this breaks certain boards which have no interrupt support,
like Huawei D03.

Indeed, the 8250 DT bindings state that interrupts should be supported -
not must.

To fix, switch from irq_of_parse_and_map() to of_irq_get(), which
does relay whether the IRQ host controller domain is not ready, i.e.
defer probe, instead of assuming it.

Fixes: c58caaab3bf8 ("serial: 8250: of: Defer probe on missing IRQ")
Signed-off-by: John Garry <john.garry@huawei.com>
Reviewed-by: Rob Herring <robh@kernel.org>
Reviewed-by: Alexander Sverdlin <alexander.sverdlin@nokia.com>
Tested-by: Alexander Sverdlin <alexander.sverdlin@nokia.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/8250/8250_of.c