]> asedeno.scripts.mit.edu Git - linux.git/commit
xfs: undo block reservation correctly in xfs_trans_reserve()
authorEryu Guan <eguan@redhat.com>
Tue, 13 Sep 2016 21:39:07 +0000 (07:39 +1000)
committerDave Chinner <david@fromorbit.com>
Tue, 13 Sep 2016 21:39:07 +0000 (07:39 +1000)
commita27f6ef4e636c2437090b87c4eb0f587b60d7123
tree68ea5e98ff38af2200c698d599368780cbae099c
parentea78d80866ce375defb2fdd1c8a3aafec95e0f85
xfs: undo block reservation correctly in xfs_trans_reserve()

"blocks" should be added back to fdblocks at undo time, not taken
away, i.e. the minus sign should not be used.

This is a regression introduced by commit 0d485ada404b ("xfs: use
generic percpu counters for free block counter"). And it's found by
code inspection, I didn't it in real world, so there's no
reproducer.

Signed-off-by: Eryu Guan <eguan@redhat.com>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
fs/xfs/xfs_trans.c