]> asedeno.scripts.mit.edu Git - linux.git/commit
xen-netfront: mark expected switch fall-through
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Mon, 15 Apr 2019 21:11:41 +0000 (16:11 -0500)
committerDavid S. Miller <davem@davemloft.net>
Wed, 17 Apr 2019 04:03:02 +0000 (21:03 -0700)
commita32b9d91b72588d6d90ba2772cd431a94b0122a0
treeed0c85fdb24606f4ff985782e2b00548aff58b33
parent432bc230700f86801cffa5e159e05dea6229f722
xen-netfront: mark expected switch fall-through

In preparation to enabling -Wimplicit-fallthrough, mark switch
cases where we are expecting to fall through.

This patch fixes the following warning:

drivers/net/xen-netfront.c: In function ‘netback_changed’:
drivers/net/xen-netfront.c:2038:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
   if (dev->state == XenbusStateClosed)
      ^
drivers/net/xen-netfront.c:2041:2: note: here
  case XenbusStateClosing:
  ^~~~

Warning level 3 was used: -Wimplicit-fallthrough=3

Notice that, in this particular case, the code comment is modified
in accordance with what GCC is expecting to find.

This patch is part of the ongoing efforts to enable
-Wimplicit-fallthrough.

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/xen-netfront.c