]> asedeno.scripts.mit.edu Git - linux.git/commit
drm/vmwgfx: Zero initialize handle in vmw_execbuf_process
authorNathan Chancellor <natechancellor@gmail.com>
Tue, 12 Mar 2019 03:24:46 +0000 (20:24 -0700)
committerDeepak Rawat <drawat@vmware.com>
Mon, 8 Apr 2019 17:29:05 +0000 (10:29 -0700)
commita5020f4f537ff1a0b73ea4eb78be185c34b261ae
treeb728d7813277af77d18b04f7ab69b22820486010
parent11c454196610ae25784ac19dc3f886a4328007e4
drm/vmwgfx: Zero initialize handle in vmw_execbuf_process

When building with -Wsometimes-uninitialized, Clang warns:

drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c:3964:7: warning: variable
'handle' is used uninitialized whenever '?:' condition is false
[-Wsometimes-uninitialized]

It's not wrong; however, in practice, this is never an issue because
the value of handle isn't used when user_fence_rep is NULL because
vmw_execbuf_copy_fence_user returns immediately when that is the case.
Just zero initialize this variable so that Clang no longer warns.

Link: https://github.com/ClangBuiltLinux/linux/issues/397
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Deepak Rawat <drawat@vmware.com>
drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c