]> asedeno.scripts.mit.edu Git - linux.git/commit
selftests: fib_tests: Fix 'Command line is not complete' errors
authorDavid Ahern <dsahern@gmail.com>
Tue, 9 Apr 2019 21:23:10 +0000 (14:23 -0700)
committerDavid S. Miller <davem@davemloft.net>
Thu, 11 Apr 2019 21:17:59 +0000 (14:17 -0700)
commita5f622984a623df9a84cf43f6b098d8dd76fbe05
treefdfb94880859dc7af51dda31335841e7a6620956
parentd3706566ae3d92677b932dd156157fd6c72534b1
selftests: fib_tests: Fix 'Command line is not complete' errors

A couple of tests are verifying a route has been removed. The helper
expects the prefix as the first part of the expected output. When
checking that a route has been deleted the prefix is empty leading
to an invalid ip command:

  $ ip ro ls match
  Command line is not complete. Try option "help"

Fix by moving the comparison of expected output and output to a new
function that is used by both check_route and check_route6. Use the
new helper for the 2 checks on route removal.

Also, remove the reset of 'set -x' in route_setup which overrides the
user managed setting.

Fixes: d69faad76584c ("selftests: fib_tests: Add prefix route tests with metric")
Signed-off-by: David Ahern <dsahern@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
tools/testing/selftests/net/fib_tests.sh