]> asedeno.scripts.mit.edu Git - linux.git/commit
thunderbolt: Drop sequence number check from tb_xdomain_match()
authorMika Westerberg <mika.westerberg@linux.intel.com>
Wed, 25 Oct 2017 09:27:34 +0000 (12:27 +0300)
committerDavid S. Miller <davem@davemloft.net>
Fri, 27 Oct 2017 03:00:00 +0000 (12:00 +0900)
commita78ec0d4f0eada03378413d51c92d0c1253133fa
treefdb309bb341cbb8eae0be40250815d44efaf9f91
parenta8ff8ccb45d37efa64476958fc5e9a8d9716b23b
thunderbolt: Drop sequence number check from tb_xdomain_match()

Commit 9a03c3d398c1 ("thunderbolt: Fix a couple right shifting to zero
bugs") revealed an issue that was previously hidden because we never
actually compared received XDomain message sequence numbers properly.
The idea with these sequence numbers is that the responding host uses
the same sequence number that was in the request packet which we can
then check at the requesting host.

However, testing against macOS it looks like it does not follow this but
instead uses some other logic. Windows driver on the other hand handles
it the same way than Linux.

In order to be able to talk to macOS again, fix this so that we drop the
whole sequence number check. This effectively works exactly the same
than it worked before the aforementioned commit. This also follows the
logic the original P2P networking code used.

Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/thunderbolt/xdomain.c