]> asedeno.scripts.mit.edu Git - linux.git/commit
phy: fix error case of phy_led_triggers_(un)register
authorWoojung Huh <woojung.huh@microchip.com>
Wed, 23 Nov 2016 23:10:33 +0000 (23:10 +0000)
committerDavid S. Miller <davem@davemloft.net>
Sat, 26 Nov 2016 00:57:57 +0000 (19:57 -0500)
commita7dac9f9c1695d7470b2f4e7447513e4a71b7c1b
tree1118e18f73b9b8c74b7a049f4c48395ee2b2212a
parentf52dffe049ee11ecc02588a118fbe4092672fbaa
phy: fix error case of phy_led_triggers_(un)register

When phy_init_hw() fails at phy_attach_direct();
- phy_detach() calls phy_led_triggers_unregister() without
  previous call of phy_led_triggers_register().
- still call phy_led_triggers_register() and cause memory leak.

Fixes: 2e0bc452f472 ("net: phy: leds: add support for led triggers on phy link state change")
Signed-off-by: Woojung Huh <woojung.huh@microchip.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/phy/phy_device.c
drivers/net/phy/phy_led_triggers.c