]> asedeno.scripts.mit.edu Git - linux.git/commit
rocker: fix possible null pointer dereference in rocker_router_fib_event_work
authorJiri Pirko <jiri@mellanox.com>
Thu, 1 Feb 2018 11:21:15 +0000 (12:21 +0100)
committerDavid S. Miller <davem@davemloft.net>
Thu, 1 Feb 2018 14:50:52 +0000 (09:50 -0500)
commita83165f00f16c0e0ef5b7cec3cbd0d4788699265
tree14abea04ec1c7e69c927273f938c5fb0a5dbb4e9
parent0ba987181028ab41cdc68fa91b74c98d97b93ff3
rocker: fix possible null pointer dereference in rocker_router_fib_event_work

Currently, rocker user may experience following null pointer
derefence bug:

[    3.062141] BUG: unable to handle kernel NULL pointer dereference at 00000000000000d0
[    3.065163] IP: rocker_router_fib_event_work+0x36/0x110 [rocker]

The problem is uninitialized rocker->wops pointer that is initialized
only with the first initialized port. So move the port initialization
before registering the fib events.

Fixes: 936bd486564a ("rocker: use FIB notifications instead of switchdev calls")
Signed-off-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/rocker/rocker_main.c