]> asedeno.scripts.mit.edu Git - linux.git/commit
iwlwifi: Fix double-free problems in iwl_req_fw_callback()
authorJia-Ju Bai <baijiaju1990@gmail.com>
Wed, 29 May 2019 13:39:54 +0000 (16:39 +0300)
committerKalle Valo <kvalo@codeaurora.org>
Sat, 1 Jun 2019 05:04:50 +0000 (08:04 +0300)
commita8627176b0de7ba3f4524f641ddff4abf23ae4e4
treee762eb13b0a2e0048644de85829f841ee4e11f75
parentb17dc0632a17fbfe66b34ee7c24e1cc10cfc503e
iwlwifi: Fix double-free problems in iwl_req_fw_callback()

In the error handling code of iwl_req_fw_callback(), iwl_dealloc_ucode()
is called to free data. In iwl_drv_stop(), iwl_dealloc_ucode() is called
again, which can cause double-free problems.

To fix this bug, the call to iwl_dealloc_ucode() in
iwl_req_fw_callback() is deleted.

This bug is found by a runtime fuzzing tool named FIZZER written by us.

Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
drivers/net/wireless/intel/iwlwifi/iwl-drv.c