]> asedeno.scripts.mit.edu Git - linux.git/commit
EDAC, i5000, i5400: Fix definition of NRECMEMB register
authorJérémy Lefaure <jeremy.lefaure@lse.epita.fr>
Thu, 29 Jun 2017 00:57:29 +0000 (20:57 -0400)
committerBorislav Petkov <bp@suse.de>
Thu, 29 Jun 2017 08:33:13 +0000 (10:33 +0200)
commita8c8261425649da58bdf08221570e5335ad33a31
tree5be98bafe7520552305be37670e7c7ae909bc74e
parent77641dacead2cbfe22d10f4e7c07867d86900057
EDAC, i5000, i5400: Fix definition of NRECMEMB register

In the i5000 and i5400 drivers, the NRECMEMB register is defined as a
16-bit value, which results in wrong shifts in the code, as reported by
sparse.

In the datasheets ([1], section 3.9.22.20 and [2], section 3.9.22.21),
this register is a 32-bit register. A u32 value for the register fixes
the wrong shifts warnings and matches the datasheet.

Also fix the mask to access to the CAS bits [27:16] in the i5000 driver.

[1]: https://www.intel.com/content/dam/doc/datasheet/5000p-5000v-5000z-chipset-memory-controller-hub-datasheet.pdf
[2]: https://www.intel.se/content/dam/doc/datasheet/5400-chipset-memory-controller-hub-datasheet.pdf

Signed-off-by: Jérémy Lefaure <jeremy.lefaure@lse.epita.fr>
Cc: linux-edac <linux-edac@vger.kernel.org>
Link: http://lkml.kernel.org/r/20170629005729.8478-1-jeremy.lefaure@lse.epita.fr
Signed-off-by: Borislav Petkov <bp@suse.de>
drivers/edac/i5000_edac.c
drivers/edac/i5400_edac.c