]> asedeno.scripts.mit.edu Git - linux.git/commit
staging: lustre: tidy up ldlm_resource_putref()
authorNeilBrown <neilb@suse.com>
Thu, 29 Mar 2018 04:26:48 +0000 (15:26 +1100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 23 Apr 2018 12:46:39 +0000 (14:46 +0200)
commitaa4cc28e4df70ffc2c30ae5c5b8fe7ae5f8c1127
tree23cb11a833d114cd8e45ed91784be08895601e96
parent14cfbd217758c34aba53fcae1ecf064899967a33
staging: lustre: tidy up ldlm_resource_putref()

1/ the return value of ldlm_resource_putref() is never
  used, so change it to return 'void'.
2/ Move all of the code to run on the last putref to
   __ldlm_resource_putref_final().  This means a lock
   is taken in one function and dropped in another, but
   that isn't too uncommon, and will disappear in a future
   patch.
   Now that the code it together, it becomes apparent that
   we are dropping a ref on the namespace *before* the last
   use.  So keep the ref until after.

Signed-off-by: NeilBrown <neilb@suse.com>
Reviewed-by: James Simmons <jsimmons@infradead.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/lustre/lustre/include/lustre_dlm.h
drivers/staging/lustre/lustre/ldlm/ldlm_resource.c