]> asedeno.scripts.mit.edu Git - linux.git/commit
drm/i915: disable set/get_tiling ioctl on gen12+
authorDaniel Vetter <daniel.vetter@ffwll.ch>
Tue, 20 Aug 2019 19:54:51 +0000 (21:54 +0200)
committerJosé Roberto de Souza <jose.souza@intel.com>
Wed, 4 Sep 2019 19:31:12 +0000 (12:31 -0700)
commitab016914984e2a7405756dfc8a8e4cb54a4c1b48
tree8f21a15651f996870e3de5efb8c10733a0a7a965
parente838bfa8e170415fa3cc8e83ecb171e809c0c422
drm/i915: disable set/get_tiling ioctl on gen12+

The cpu (de)tiler hw is gone, this stopped being useful. Plus it never
supported any of the fancy new tiling formats, which means userspace
also stopped using the magic side-channel this provides.

This would totally break a lot of the igts, but they're already broken
for the same reasons as userspace on gen12 would be.

v2: Look at ggtt->num_fences instead, that also avoids the need for a
comment (Chris). This also means that gen12 support really needs to
make sure num_fences is set to 0. There is a patch for that, but it
checks for HAS_MAPPABLE_APERTURE, which I'm not sure is the right
thing really. Adding relevant people.

Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Cc: Stuart Summers <stuart.summers@intel.com>
Cc: Matthew Auld <matthew.auld@intel.com>
Cc: Kenneth Graunke <kenneth@whitecape.org>
Cc: Jason Ekstrand <jason@jlekstrand.net>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
Reviewed-by: José Roberto de Souza <jose.souza@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190820195451.15671-1-daniel.vetter@ffwll.ch
drivers/gpu/drm/i915/gem/i915_gem_tiling.c