]> asedeno.scripts.mit.edu Git - linux.git/commit
EDAC: Fix used after kfree() error in edac_unregister_sysfs()
authorTony Luck <tony.luck@intel.com>
Thu, 21 Apr 2016 17:34:14 +0000 (10:34 -0700)
committerBorislav Petkov <bp@suse.de>
Sat, 23 Apr 2016 11:23:54 +0000 (13:23 +0200)
commitab67b6c22d8506b060a66ed0ce1a3e14e3b075e4
tree1ad90c7cb045e161d6ab5718165af1eb498be4b0
parent1aa6eb5c5b35771cfb28265eccd99b4b203b4154
EDAC: Fix used after kfree() error in edac_unregister_sysfs()

Code flow looks like this:

  device_unregister(&mci->dev);
   -> kobject_put+0x25/0x50
    -> kobject_cleanup+0x77/0x190
      -> device_release+0x32/0xa0
-> mci_attr_release+0x36/0x70
  -> kfree(mci);
  bus_unregister(mci->bus);

Fix is to grab a local copy of "mci->bus" and use that when we call
bus_unregister().

Signed-off-by: Tony Luck <tony.luck@intel.com>
Acked-by: Aristeu Rozanski <aris@redhat.com>
Cc: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Cc: linux-edac <linux-edac@vger.kernel.org>
Link: http://lkml.kernel.org/r/21d595b0ab3d718d9cb206647f4ec91c05e62ec4.1461261078.git.tony.luck@intel.com
Signed-off-by: Borislav Petkov <bp@suse.de>
drivers/edac/edac_mc_sysfs.c