]> asedeno.scripts.mit.edu Git - linux.git/commit
drm/i915: Don't skip audio enable if ELD is bogus
authorVille Syrjälä <ville.syrjala@linux.intel.com>
Tue, 30 Apr 2019 14:29:00 +0000 (17:29 +0300)
committerVille Syrjälä <ville.syrjala@linux.intel.com>
Thu, 2 May 2019 14:06:58 +0000 (17:06 +0300)
commitabf4b8ed42e9dc64bdf05320273ee41f82fcd754
treeca18794e505fd43d0863618f898876891623fbe2
parent117aca43f71792e0fb08c38871cdabc3c5cee920
drm/i915: Don't skip audio enable if ELD is bogus

We've already committed to enabling audio when intel_audio_codec_enable()
is called. We can't back out even if the ELD has turned sour in the
meantime. So just spew some debug log and plow ahead. Otherwise the
state checker gets unhappy when audio isn't enabled when it is
expected to be.

I suppose we really ought to precompute the ELD as well, but
let's just toss in a FIXME for the future.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103841
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190430142901.7302-1-ville.syrjala@linux.intel.com
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
drivers/gpu/drm/i915/intel_audio.c