]> asedeno.scripts.mit.edu Git - linux.git/commit
rcu: Make call_rcu() leak callbacks for debug-object errors
authorPaul E. McKenney <paulmck@linux.vnet.ibm.com>
Tue, 23 Apr 2013 20:20:57 +0000 (13:20 -0700)
committerPaul E. McKenney <paulmck@linux.vnet.ibm.com>
Mon, 19 Aug 2013 00:40:03 +0000 (17:40 -0700)
commitae15018456c44b742d352af323e0b89eae4a6383
tree784bd33ca97df210d581b59b9c3d8118ef057181
parentb778ae25366e6f3891fe51306f56a3bca211975d
rcu: Make call_rcu() leak callbacks for debug-object errors

If someone does a duplicate call_rcu(), the worst thing the second
call_rcu() could do would be to actually queue the callback the second
time because doing so corrupts whatever list the callback was already
queued on.  This commit therefore makes __call_rcu() check the new
return value from debug-objects and leak the callback upon error.
This commit also substitutes rcu_leak_callback() for whatever callback
function was previously in place in order to avoid freeing the callback
out from under any readers that might still be referencing it.

These changes increase the probability that the debug-objects error
messages will actually make it somewhere visible.

Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: Sedat Dilek <sedat.dilek@gmail.com>
Cc: Davidlohr Bueso <davidlohr.bueso@hp.com>
Cc: Rik van Riel <riel@surriel.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Tested-by: Sedat Dilek <sedat.dilek@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
kernel/rcu.h
kernel/rcutree.c