]> asedeno.scripts.mit.edu Git - linux.git/commit
dmaengine: stm32-dma: Fix unchecked deference of chan->desc
authorM'boumba Cedric Madianga <cedric.madianga@gmail.com>
Mon, 7 Dec 2015 11:00:28 +0000 (12:00 +0100)
committerVinod Koul <vinod.koul@intel.com>
Thu, 10 Dec 2015 04:15:22 +0000 (09:45 +0530)
commitaea08a5dfadf387153cdbbff89f775b0e19d32e4
treee131357f4158ae6de8a7ce51b06983ca80c48dc1
parentb341b4a13ca2c6ea8a426a9befb4dec0d7040860
dmaengine: stm32-dma: Fix unchecked deference of chan->desc

'commit d8b468394fb7 ("dmaengine: Add STM32 DMA driver")' leads to the
following Smatch complaint:

drivers/dma/stm32-dma.c:562 stm32_dma_issue_pending()
    error: we previously assumed 'chan->desc' could be null (see line 560)

So, this patch fixes the unchecked dereference of chan->desc by returning
operation not permitted error when stm32_dma_start_transfer() does not
succeed to allocate a virtual channel descriptor.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: M'boumba Cedric Madianga <cedric.madianga@gmail.com>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
drivers/dma/stm32-dma.c