]> asedeno.scripts.mit.edu Git - linux.git/commit
drm/amd/display: remove get_position() of underlay
authorShirish S <shirish.s@amd.com>
Thu, 8 Jun 2017 06:25:06 +0000 (11:55 +0530)
committerAlex Deucher <alexander.deucher@amd.com>
Tue, 26 Sep 2017 22:07:59 +0000 (18:07 -0400)
commitaed8b319180f18402ed90929f85e2b3e5b81e71d
tree145a65c20a3093be96e536d4868f7c3b7eca14cb
parent561f3a4db315d639b93adf86eedbb8405dd81fbe
drm/amd/display: remove get_position() of underlay

get_position() returns CRTC vertical/horizontal counters,
hence it is not applicable for underlay which is plane and not
attached to one crtc.
This patch hence removes the callback from dce110_tg_v_funcs
and hence fixes a bug in dc_debug.c where in
get_position() for underlay pipe is called un-conditionally.

Witout this patch get_position() is called in case one has
to update underlay plane's data,
since callback implmented with an ASSERT(),
the old_surface_count and new_surface_count mismatches; causing
only one plane update which is not right and also assert makes the
rendering slow.

Signed-off-by: Shirish S <shirish.s@amd.com>
Reviewed-by: Tony Cheng <Tony.Cheng@amd.com>
Acked-by: Harry Wentland <Harry.Wentland@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/dc/core/dc_debug.c
drivers/gpu/drm/amd/display/dc/dce110/dce110_timing_generator_v.c