]> asedeno.scripts.mit.edu Git - linux.git/commit
tools lib traceevent: Do not free tep->cmdlines in add_new_comm() on failure
authorSteven Rostedt (VMware) <rostedt@goodmis.org>
Wed, 28 Aug 2019 19:05:28 +0000 (15:05 -0400)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Thu, 29 Aug 2019 11:36:12 +0000 (08:36 -0300)
commitb0215e2d6a18d8331b2d4a8b38ccf3eff783edb1
tree5d7ede7efab7142f7132a71ad67e00c4418c76a2
parentb397f8468fa27f08b83b348ffa56a226f72453af
tools lib traceevent: Do not free tep->cmdlines in add_new_comm() on failure

If the re-allocation of tep->cmdlines succeeds, then the previous
allocation of tep->cmdlines will be freed. If we later fail in
add_new_comm(), we must not free cmdlines, and also should assign
tep->cmdlines to the new allocation. Otherwise when freeing tep, the
tep->cmdlines will be pointing to garbage.

Fixes: a6d2a61ac653a ("tools lib traceevent: Remove some die() calls")
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: linux-trace-devel@vger.kernel.org
Cc: stable@vger.kernel.org
Link: http://lkml.kernel.org/r/20190828191819.970121417@goodmis.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/lib/traceevent/event-parse.c