]> asedeno.scripts.mit.edu Git - linux.git/commit
pinctrl: sh-pfc: Remove incomplete flag "cfg->type"
authorYoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Thu, 8 Aug 2019 06:19:02 +0000 (15:19 +0900)
committerGeert Uytterhoeven <geert+renesas@glider.be>
Mon, 12 Aug 2019 13:55:26 +0000 (15:55 +0200)
commitb13431ed6eab808affbd796a7c8caf05c7ae4cdd
treeeb710d50ca6429c3afe865748e4b21c8f4fbbcbd
parent1d4ba593d02e8ec41c2baaabdce9f62b71062dc7
pinctrl: sh-pfc: Remove incomplete flag "cfg->type"

The old commit c58d9c1b26e3 ("sh-pfc: Implement generic pinconf
support") broke the cfg->type flag to PINMUX_TYPE_FUNCTION because
sh_pfc_pinconf_set() didn't call sh_pfc_reconfig_pin().
Now if we fix the cfg->type condition, it gets worse because:
 - Some drivers might be deferred so that .set_mux() will be called
   multiple times.
 - In such the case, the sh-pfc driver returns -EBUSY even if
   the group is the same, and then that driver fails to probe.

Since the pinctrl subsystem already has such conditions according
to @set_mux and @gpio_request_enable, this patch just remove
the incomplete flag from sh-pfc/pinctrl.c.

Fixes: c58d9c1b26e3 ("sh-pfc: Implement generic pinconf support")
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
drivers/pinctrl/sh-pfc/pinctrl.c