]> asedeno.scripts.mit.edu Git - linux.git/commit
tracing: Uninitialized variable in create_tracing_map_fields()
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 28 Mar 2018 11:48:15 +0000 (14:48 +0300)
committerSteven Rostedt (VMware) <rostedt@goodmis.org>
Fri, 6 Apr 2018 12:56:50 +0000 (08:56 -0400)
commitb28d7b2dc27f0eef1ae608b49d6860f2463910f1
tree3d39a6a0f1f4c592e8a201206c5ee0d805a7ac0f
parentad452870c66e05819a99b491b500a13989a1c502
tracing: Uninitialized variable in create_tracing_map_fields()

Smatch complains that idx can be used uninitialized when we check if
(idx < 0).  It has to be the first iteration through the loop and the
HIST_FIELD_FL_STACKTRACE bit has to be clear and the HIST_FIELD_FL_VAR
bit has to be set to reach the bug.

Link: http://lkml.kernel.org/r/20180328114815.GC29050@mwanda
Fixes: 30350d65ac56 ("tracing: Add variable support to hist triggers")
Acked-by: Tom Zanussi <tom.zanussi@linux.intel.com>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
kernel/trace/trace_events_hist.c