]> asedeno.scripts.mit.edu Git - linux.git/commit
dnotify: Handle errors from fsnotify_add_mark_locked() in fcntl_dirnotify()
authorJan Kara <jack@suse.cz>
Tue, 31 Oct 2017 08:53:28 +0000 (09:53 +0100)
committerJan Kara <jack@suse.cz>
Tue, 31 Oct 2017 16:41:04 +0000 (17:41 +0100)
commitb3a0066005821acdc0cdb092cb72587182ab583f
tree9372eb76b9f3d2242c2a6ac5c8724f7546cd5e98
parentff5abbe799e29099695cb8b5b2f198dd8b8bdf26
dnotify: Handle errors from fsnotify_add_mark_locked() in fcntl_dirnotify()

fsnotify_add_mark_locked() can fail but we do not check its return
value. This didn't matter before commit 9dd813c15b2c "fsnotify: Move
mark list head from object into dedicated structure" as none of possible
failures could happen for dnotify but after that commit -ENOMEM can be
returned. Handle this error properly in fcntl_dirnotify() as
otherwise we just hit BUG_ON(dn_mark->dn) in dnotify_free_mark().

Reviewed-by: Amir Goldstein <amir73il@gmail.com>
Reported-by: syzkaller
Fixes: 9dd813c15b2c101168808d4f5941a29985758973
Signed-off-by: Jan Kara <jack@suse.cz>
fs/notify/dnotify/dnotify.c