]> asedeno.scripts.mit.edu Git - linux.git/commit
drm/sun4i: Clear encoder->bridge if a bridge is not found
authorChen-Yu Tsai <wens@csie.org>
Thu, 1 Sep 2016 06:13:32 +0000 (14:13 +0800)
committerMaxime Ripard <maxime.ripard@free-electrons.com>
Thu, 1 Sep 2016 16:46:06 +0000 (18:46 +0200)
commitb5644a5e72f0a18c0cddf887bec1e1370cf67a8c
tree08b58bd05ffaa200c237d5bffeab0743742c62d0
parent4b30950252265140139ce441fd7d8743d1d6052e
drm/sun4i: Clear encoder->bridge if a bridge is not found

The KMS helpers (drm_atomic_helper_check_modeset/mode_fixup) pass
encoder->bridge directly to drm_bridge_mode_fixup, which expects a
valid pointer, or NULL (in which case it just returns).

Clear encoder->bridge if a bridge is not found, instead of keeping
the ERR_PTR value.

Since other drm_bridge functions also follow this pattern of checking
for a non-NULL pointer, we can drop the ifs around the calls and just
pass the pointer directly.

Fixes: 894f5a9f4b4a ("drm/sun4i: Add bridge support")
Signed-off-by: Chen-Yu Tsai <wens@csie.org>
Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
drivers/gpu/drm/sun4i/sun4i_rgb.c