]> asedeno.scripts.mit.edu Git - linux.git/commit
net: stmmac: selftest: avoid large stack usage
authorArnd Bergmann <arnd@arndb.de>
Thu, 19 Sep 2019 12:33:43 +0000 (14:33 +0200)
committerJakub Kicinski <jakub.kicinski@netronome.com>
Sun, 22 Sep 2019 02:46:14 +0000 (19:46 -0700)
commitb6b6cc9acd7b99df216c007e9565aebdc2c77469
treed955ee468ded5c6100c4d58a5b2f6f975746c25e
parenta8d570de0cc6acd6dc994515f163ccbc5e54ab60
net: stmmac: selftest: avoid large stack usage

Putting a struct stmmac_rss object on the stack is a bad idea,
as it exceeds the warning limit for a stack frame on 32-bit architectures:

drivers/net/ethernet/stmicro/stmmac/stmmac_selftests.c:1221:12: error: stack frame size of 1208 bytes in function '__stmmac_test_l3filt' [-Werror,-Wframe-larger-than=]
drivers/net/ethernet/stmicro/stmmac/stmmac_selftests.c:1338:12: error: stack frame size of 1208 bytes in function '__stmmac_test_l4filt' [-Werror,-Wframe-larger-than=]

As the object is the trivial empty case, change the called function
to accept a NULL pointer to mean the same thing and remove the
large variable in the two callers.

Fixes: 4647e021193d ("net: stmmac: selftests: Add selftest for L3/L4 Filters")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Jose Abreu <joabreu@synopsys.com>
Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c
drivers/net/ethernet/stmicro/stmmac/stmmac_selftests.c