]> asedeno.scripts.mit.edu Git - linux.git/commit
i2c: ismt: Don't duplicate the receive length for block reads
authorStephen Douthit <stephend@adiengineering.com>
Mon, 7 Aug 2017 21:10:59 +0000 (17:10 -0400)
committerWolfram Sang <wsa@the-dreams.de>
Tue, 29 Aug 2017 20:12:30 +0000 (22:12 +0200)
commitb6c159a9cb69c2cf0bf59d4e12c3a2da77e4d994
tree779a14fa4036990b8ca73e0d87bffc306703ba60
parentcc4a41fe5541a73019a864883297bd5043aa6d98
i2c: ismt: Don't duplicate the receive length for block reads

According to Table 15-14 of the C2000 EDS (Intel doc #510524) the
rx data pointed to by the descriptor dptr contains the byte count.

desc->rxbytes reports all bytes read on the wire, including the
"byte count" byte.  So if a device sends 4 bytes in response to a
block read, on the wire and in the DMA buffer we see:

count data1 data2 data3 data4
 0x04  0xde  0xad  0xbe  0xef

That's what we want to return in data->block to the next level.

Instead we were actually prefixing that with desc->rxbytes:

bad
count count data1 data2 data3 data4
 0x05  0x04  0xde  0xad  0xbe  0xef

This was discovered while developing a BMC solution relying on the
ipmi_ssif.c driver which was trying to interpret the bogus length
field as part of the IPMI response.

Signed-off-by: Stephen Douthit <stephend@adiengineering.com>
Tested-by: Dan Priamo <danp@adiengineering.com>
Acked-by: Neil Horman <nhorman@tuxdriver.com>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
Cc: stable@kernel.org
drivers/i2c/busses/i2c-ismt.c