]> asedeno.scripts.mit.edu Git - linux.git/commit
rtnetlink: bridge: use ext_ack instead of printk
authorFlorian Westphal <fw@strlen.de>
Tue, 10 Oct 2017 15:10:04 +0000 (17:10 +0200)
committerDavid S. Miller <davem@davemloft.net>
Tue, 10 Oct 2017 20:16:02 +0000 (13:16 -0700)
commitb88d12e4a4ff5b99dcaf9b35a30ad2597cb2fd8a
tree7abbfd46f966d8d6509820dabe20fc6fd02bc49a
parent8f88f74a1641f57607a2417669e0e02b768796b4
rtnetlink: bridge: use ext_ack instead of printk

We can now piggyback error strings to userspace via extended acks
rather than using printk.

Before:
bridge fdb add 01:02:03:04:05:06 dev br0 vlan 4095
RTNETLINK answers: Invalid argument

After:
bridge fdb add 01:02:03:04:05:06 dev br0 vlan 4095
Error: invalid vlan id.

v3: drop 'RTM_' prefixes, suggested by David Ahern, they
are not useful, the add/del in bridge command line is enough.

Also reword error in response to malformed/bad vlan id attribute
size.

Cc: David Ahern <dsahern@gmail.com>
Signed-off-by: Florian Westphal <fw@strlen.de>
Reviewed-by: David Ahern <dsahern@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/core/rtnetlink.c