]> asedeno.scripts.mit.edu Git - linux.git/commit
media: vivid: fix potential integer overflow on left shift
authorColin Ian King <colin.king@canonical.com>
Thu, 27 Jun 2019 08:05:41 +0000 (04:05 -0400)
committerMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Tue, 23 Jul 2019 12:49:17 +0000 (08:49 -0400)
commitb98fd3cb6db8dbba6377c41a66c6b673f9d93da3
treecb8b308efdfaf21d6e2ba562d1487692ad53efa2
parentb61789f53d49db8ca1f6b8fed411b317b4e8f044
media: vivid: fix potential integer overflow on left shift

There is a potential integer overflow when int 2 is left shifted
as this is evaluated using 32 bit arithmetic but is being used in
a context that expects an expression of type s64.  Fix this by
generating a mask using GENMASK to avoid a 32 bit overflow.

Addresses-Coverity: ("Unintentional integer overflow")

Fixes: 8a99e9faa131 ("media: vivid: add HDMI (dis)connect RX emulation")
Fixes: 79a792dafac6 ("media: vivid: add HDMI (dis)connect TX emulation")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
drivers/media/platform/vivid/vivid-ctrls.c