]> asedeno.scripts.mit.edu Git - linux.git/commit
drm/amdgpu: Check if SW SMU is supported before accessing funcs
authorLeo Li <sunpeng.li@amd.com>
Thu, 18 Apr 2019 15:53:58 +0000 (11:53 -0400)
committerAlex Deucher <alexander.deucher@amd.com>
Tue, 23 Apr 2019 22:27:25 +0000 (17:27 -0500)
commitbb20be7510203db17c6c09f888cf328e307f1701
tree269b8421a28e63de42bd5b1c05012b07cf67fc65
parent3b8cea6f645c909783455265f2cb0fb64fd68f51
drm/amdgpu: Check if SW SMU is supported before accessing funcs

smu.ppt_funcs is only initialized for ASICs supporting SW SMU.

On a Hawaii ASIC, attempting to access the udev attribute
ATTRS{power_dpm_state} will cause a null pointer deref in
amdgpu_get_dpm_state() because of this.

Fix by checking if SW SMU is supported first.

Signed-off-by: Leo Li <sunpeng.li@amd.com>
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Reviewed-by: Huang Rui <ray.huang@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c