]> asedeno.scripts.mit.edu Git - linux.git/commit
media: venus: fix loop wrap in cleanup of clks
authorColin Ian King <colin.king@canonical.com>
Thu, 22 Jun 2017 17:27:21 +0000 (14:27 -0300)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Sat, 24 Jun 2017 12:38:53 +0000 (09:38 -0300)
commitbc8e2d627a5888c48d553abe534c341c1c096a5e
tree2c8bea73524611e498b639d851558c3c9d902159
parent13c2bede49f996ca34a368dfe05be53d6b2ccc22
media: venus: fix loop wrap in cleanup of clks

The current pre-decrement is incorrect and should be replaced
with a post-decrement. Consider the case where the very first
clk_prepare_enable fails when i is 0; in this case the error
clean up will decrement the unsigned int which wraps to the
largest unsigned int value causing an array out of bounds read
on core->clks[i].

Detected by CoverityScan, CID#1446590 ("Out-of-bounds read")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Hans Verkuil <hansverk@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/media/platform/qcom/venus/core.c