]> asedeno.scripts.mit.edu Git - linux.git/commit
drivers/tty/serial: deal with 8250_core.c uninitialized warning for good
authorPaul Gortmaker <paul.gortmaker@windriver.com>
Wed, 19 Feb 2014 20:00:13 +0000 (15:00 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 1 Mar 2014 00:25:47 +0000 (16:25 -0800)
commitbd2fe272a8ec3841189e07a9a8e9879fe26a3cdc
treee5ad418c4b37010c21c4b4d3778d5cada95ac75e
parent8301bb240d0f1b1521b83342f3af8edab7131361
drivers/tty/serial: deal with 8250_core.c uninitialized warning for good

Every couple of months, someone sends a patch to fix:

drivers/tty/serial/8250/8250_core.c: In function 'serial_unlink_irq_chain':
drivers/tty/serial/8250/8250_core.c:1712:2: warning: 'i' may be used uninitialized in this function [-Wuninitialized]

and they in turn get a NACK for their efforts, and are told that
their compiler is broken.  This has been going on since at least
the year 2008:  https://lkml.org/lkml/2008/11/24/433

Lets add a comment, so that subsequent patches don't get as far as
the maintainers or the mailing lists.

Acked-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/8250/8250_core.c