]> asedeno.scripts.mit.edu Git - linux.git/commit
USB: serial: console: fix use-after-free on disconnect
authorJohan Hovold <johan@kernel.org>
Wed, 4 Oct 2017 09:01:12 +0000 (11:01 +0200)
committerJohan Hovold <johan@kernel.org>
Mon, 9 Oct 2017 10:33:04 +0000 (12:33 +0200)
commitbd998c2e0df0469707503023d50d46cf0b10c787
treee9bbaabbbff9b29fb10ddb76a24b8f618fd4fe89
parentf5d9644c5fca7d8e8972268598bb516a7eae17f9
USB: serial: console: fix use-after-free on disconnect

A clean-up patch removing two redundant NULL-checks from the console
disconnect handler inadvertently also removed a third check. This could
lead to the struct usb_serial being prematurely freed by the console
code when a driver accepts but does not register any ports for an
interface which also lacks endpoint descriptors.

Fixes: 0e517c93dc02 ("USB: serial: console: clean up sanity checks")
Cc: stable <stable@vger.kernel.org> # 4.11
Reported-by: Andrey Konovalov <andreyknvl@google.com>
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Johan Hovold <johan@kernel.org>
drivers/usb/serial/console.c