]> asedeno.scripts.mit.edu Git - linux.git/commit
loop: fix LOOP_GET_STATUS lock imbalance
authorOmar Sandoval <osandov@fb.com>
Fri, 6 Apr 2018 16:57:03 +0000 (09:57 -0700)
committerJens Axboe <axboe@kernel.dk>
Tue, 10 Apr 2018 14:38:46 +0000 (08:38 -0600)
commitbdac616db9bbadb90b7d6a406144571015e138f7
treed883f14fdc2dc308c13aae0cf80042deec2ffd6b
parent1e047eaab3bb5564f25b41e9cd3a053009f4e789
loop: fix LOOP_GET_STATUS lock imbalance

Commit 2d1d4c1e591f made loop_get_status() drop lo_ctx_mutex before
returning, but the loop_get_status_old(), loop_get_status64(), and
loop_get_status_compat() wrappers don't call loop_get_status() if the
passed argument is NULL. The callers expect that the lock is dropped, so
make sure we drop it in that case, too.

Reported-by: syzbot+31e8daa8b3fc129e75f2@syzkaller.appspotmail.com
Fixes: 2d1d4c1e591f ("loop: don't call into filesystem while holding lo_ctl_mutex")
Signed-off-by: Omar Sandoval <osandov@fb.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/block/loop.c