]> asedeno.scripts.mit.edu Git - linux.git/commit
tcp: better delivery accounting for SYN-ACK and SYN-data
authorYuchung Cheng <ycheng@google.com>
Wed, 18 Apr 2018 06:18:46 +0000 (23:18 -0700)
committerDavid S. Miller <davem@davemloft.net>
Thu, 19 Apr 2018 17:05:16 +0000 (13:05 -0400)
commitbef5767f37cfe42b1cf1ae60f01cfb4e16a7a2b8
tree7b50df5aac4c33c0b4a1d360eb9d06216cdcfad3
parent415787d7799f4fccbe8d49cb0b8e5811be6b0389
tcp: better delivery accounting for SYN-ACK and SYN-data

the tcp_sock:delivered has inconsistent accounting for SYN and FIN.
1. it counts pure FIN
2. it counts pure SYN
3. it counts SYN-data twice
4. it does not count SYN-ACK

For congestion control perspective it does not matter much as C.C. only
cares about the difference not the aboslute value. But the next patch
would export this field to user-space so it's better to report the absolute
value w/o these caveats.

This patch counts SYN, SYN-ACK, or SYN-data delivery once always in
the "delivered" field.

Signed-off-by: Yuchung Cheng <ycheng@google.com>
Reviewed-by: Neal Cardwell <ncardwell@google.com>
Reviewed-by: Soheil Hassas Yeganeh <soheil@google.com>
Reviewed-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/tcp_input.c