]> asedeno.scripts.mit.edu Git - linux.git/commit
powerpc/kexec_file: Fix error code when trying to load kdump kernel
authorThiago Jung Bauermann <bauerman@linux.vnet.ibm.com>
Thu, 29 Mar 2018 19:05:43 +0000 (16:05 -0300)
committerMichael Ellerman <mpe@ellerman.id.au>
Sat, 31 Mar 2018 13:47:44 +0000 (00:47 +1100)
commitbf8a1abc3ddbd6e9a8312ea7d96e5dd89c140f18
treebcd45aa12cf5a11000da1e4a8004d01f32a2ed29
parent7e1405917c145edbb7d4cd520e890e44161dd7be
powerpc/kexec_file: Fix error code when trying to load kdump kernel

kexec_file_load() on powerpc doesn't support kdump kernels yet, so it
returns -ENOTSUPP in that case.

I've recently learned that this errno is internal to the kernel and
isn't supposed to be exposed to userspace. Therefore, change to
-EOPNOTSUPP which is defined in an uapi header.

This does indeed make kexec-tools happier. Before the patch, on
ppc64le:

  # ~bauermann/src/kexec-tools/build/sbin/kexec -s -p /boot/vmlinuz
  kexec_file_load failed: Unknown error 524

After the patch:

  # ~bauermann/src/kexec-tools/build/sbin/kexec -s -p /boot/vmlinuz
  kexec_file_load failed: Operation not supported

Fixes: a0458284f062 ("powerpc: Add support code for kexec_file_load()")
Cc: stable@vger.kernel.org # v4.10+
Reported-by: Dave Young <dyoung@redhat.com>
Signed-off-by: Thiago Jung Bauermann <bauerman@linux.vnet.ibm.com>
Reviewed-by: Simon Horman <horms@verge.net.au>
Reviewed-by: Dave Young <dyoung@redhat.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
arch/powerpc/kernel/machine_kexec_file_64.c