]> asedeno.scripts.mit.edu Git - linux.git/commit
scsi: sym53c8xx: Avoid undefined behaviour
authorHelge Deller <deller@gmx.de>
Thu, 10 Aug 2017 19:08:49 +0000 (21:08 +0200)
committerMartin K. Petersen <martin.petersen@oracle.com>
Fri, 25 Aug 2017 02:28:54 +0000 (22:28 -0400)
commitc0e8ed04b32307c192bcf37f5810e490e4d2739e
tree6307e7ef8c5eaa37cc02af29215d14dd2b37f438
parent8a97712e5314aefe16b3ffb4583a34deaa49de04
scsi: sym53c8xx: Avoid undefined behaviour

On parisc I see this UBSAN warning with a sym53c896:

 UBSAN: Undefined behaviour in ./drivers/scsi/sym53c8xx_2/sym_hipd.c:762:24
 index -1903078336 is out of range for type 'u32 [7]'

Avoid this warning by switching to div64_ul().

[mkp: fix typo]

Signed-off-by: Helge Deller <deller@gmx.de>
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/sym53c8xx_2/sym_hipd.c