]> asedeno.scripts.mit.edu Git - linux.git/commit
net: systemport: Fix sparse warnings in bcm_sysport_insert_tsb()
authorFlorian Fainelli <f.fainelli@gmail.com>
Mon, 2 Apr 2018 22:58:56 +0000 (15:58 -0700)
committerDavid S. Miller <davem@davemloft.net>
Wed, 4 Apr 2018 15:07:21 +0000 (11:07 -0400)
commitc0eb05585d4184596453622b5abba7d13dd20667
tree60150b002c683c5c21d1001dce04f99d7cfdfffc
parent6f89421180f15867dc1472d9edf68f82b0ed5ee6
net: systemport: Fix sparse warnings in bcm_sysport_insert_tsb()

skb->protocol is a __be16 which we would be calling htons() against,
while this is not wrong per-se as it correctly results in swapping the
value on LE hosts, this still upsets sparse. Adopt a similar pattern to
what other drivers do and just assign ip_ver to skb->protocol, and then
use htons() against the different constants such that the compiler can
resolve the values at build time.

Fixes: 80105befdb4b ("net: systemport: add Broadcom SYSTEMPORT Ethernet MAC driver")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/broadcom/bcmsysport.c