]> asedeno.scripts.mit.edu Git - linux.git/commit
x86/e820/32: Fix e820_search_gap() error handling on x86-32
authorArnd Bergmann <arnd@arndb.de>
Wed, 11 Jan 2017 14:49:04 +0000 (15:49 +0100)
committerIngo Molnar <mingo@kernel.org>
Thu, 12 Jan 2017 08:40:06 +0000 (09:40 +0100)
commitc19a5f35e315837170ee337eed21c7087ea94192
tree762128ea67bd8fc860ce527cd29a5fceacb77e7e
parent1e620f9b23e598ab936ece12233e98e97930b692
x86/e820/32: Fix e820_search_gap() error handling on x86-32

GCC correctly points out that on 32-bit kernels, e820_search_gap()
not finding a start now leads to pci_mem_start ('gapstart') being set to an
uninitialized value:

  arch/x86/kernel/e820.c: In function 'e820_setup_gap':
  arch/x86/kernel/e820.c:641:16: error: 'gapstart' may be used uninitialized in this function [-Werror=maybe-uninitialized]

This restores the behavior from before this cleanup:

  b4ed1d15b453 ("x86/e820: Make e820_search_gap() static and remove unused variables")

... defaulting to address 0x10000000 if nothing was found.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: Dan Williams <dan.j.williams@intel.com>
Cc: Denys Vlasenko <dvlasenk@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Toshi Kani <toshi.kani@hpe.com>
Cc: Wei Yang <richard.weiyang@gmail.com>
Fixes: b4ed1d15b453 ("x86/e820: Make e820_search_gap() static and remove unused variables")
Link: http://lkml.kernel.org/r/20170111144926.695369-1-arnd@arndb.de
Signed-off-by: Ingo Molnar <mingo@kernel.org>
arch/x86/kernel/e820.c