]> asedeno.scripts.mit.edu Git - linux.git/commit
pinctrl: nsp: Fix potential NULL dereference
authorWei Yongjun <weiyongjun1@huawei.com>
Wed, 11 Jul 2018 12:34:21 +0000 (12:34 +0000)
committerLinus Walleij <linus.walleij@linaro.org>
Sat, 14 Jul 2018 10:47:04 +0000 (12:47 +0200)
commitc29e9da56bebb4c2c794e871b0dc0298bbf08142
tree0c10481b45fd941058be61d76cc48f23fcee5e94
parentf90a21c898db58eaea14b8ad7e9af3b9e15e5f8a
pinctrl: nsp: Fix potential NULL dereference

platform_get_resource() may fail and return NULL, so we should
better check it's return value to avoid a NULL pointer dereference
a bit later in the code.

This is detected by Coccinelle semantic patch.

@@
expression pdev, res, n, t, e, e1, e2;
@@

res = platform_get_resource(pdev, t, n);
+ if (!res)
+   return -EINVAL;
... when != res == NULL
e = devm_ioremap_nocache(e1, res->start, e2);

Fixes: cc4fa83f66e9 ("pinctrl: nsp: add pinmux driver support for Broadcom NSP SoC")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Reviewed-by: Ray Jui <ray.jui@broadcom.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/bcm/pinctrl-nsp-mux.c