]> asedeno.scripts.mit.edu Git - linux.git/commit
can: rx-offload: can_rx_offload_irq_offload_timestamp(): continue on error
authorJeroen Hofstee <jhofstee@victronenergy.com>
Tue, 24 Sep 2019 18:45:38 +0000 (18:45 +0000)
committerMarc Kleine-Budde <mkl@pengutronix.de>
Mon, 4 Nov 2019 20:47:22 +0000 (21:47 +0100)
commitc2a9f74c9d18acfdcabd3361adc7eac82c537a66
treeb16ecacd8e1e0889461f83d2448420718ca7bb8e
parentd763ab3044f0bf50bd0e6179f6b2cf1c125d1d94
can: rx-offload: can_rx_offload_irq_offload_timestamp(): continue on error

In case of a resource shortage, i.e. the rx_offload queue will overflow
or a skb fails to be allocated (due to OOM),
can_rx_offload_offload_one() will call mailbox_read() to discard the
mailbox and return an ERR_PTR.

However can_rx_offload_irq_offload_timestamp() bails out in the error
case. In case of a resource shortage all mailboxes should be discarded,
to avoid an IRQ storm and give the system some time to recover.

Since can_rx_offload_irq_offload_timestamp() is typically called from a
while loop, all message will eventually be discarded. So let's continue
on error instead to discard them directly.

Signed-off-by: Jeroen Hofstee <jhofstee@victronenergy.com>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
drivers/net/can/rx-offload.c