]> asedeno.scripts.mit.edu Git - linux.git/commit
afs: Use struct_size() in kzalloc()
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Wed, 9 Jan 2019 17:23:54 +0000 (17:23 +0000)
committerDavid Howells <dhowells@redhat.com>
Thu, 10 Jan 2019 17:12:05 +0000 (17:12 +0000)
commitc2b8bd49d35a768d3966c5e14e8f6971f2a63439
treedd3905b2ed51027ad57009b9eff8e7a2e873667c
parenta88cc8da0279f8e481b0d90e51a0a1cffac55906
afs: Use struct_size() in kzalloc()

One of the more common cases of allocation size calculations is finding the
size of a structure that has a zero-sized array at the end, along with
memory for some number of elements for that array. For example:

struct foo {
    int stuff;
    void *entry[];
};

instance = kzalloc(sizeof(struct foo) + sizeof(void *) * count, GFP_KERNEL);

Instead of leaving these open-coded and prone to type mistakes, we can now
use the new struct_size() helper:

instance = kzalloc(struct_size(instance, entry, count), GFP_KERNEL);

This code was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: David Howells <dhowells@redhat.com>
fs/afs/server_list.c