]> asedeno.scripts.mit.edu Git - linux.git/commit
drm/modes: parse_cmdline: Stop parsing extras after bpp / refresh at ', '
authorHans de Goede <hdegoede@redhat.com>
Mon, 18 Nov 2019 15:51:24 +0000 (16:51 +0100)
committerHans de Goede <hdegoede@redhat.com>
Mon, 16 Dec 2019 11:13:17 +0000 (12:13 +0100)
commitc2ed3e941901810ad3d55ce1935fa22c5007fee4
tree4faa37a30d5e5eae68f6b847854ad2e862e1bdb1
parent83e14ea3a64f00897cc31974d3ae4e27e5a7405b
drm/modes: parse_cmdline: Stop parsing extras after bpp / refresh at ', '

Before this commit it was impossible to add an extra mode argument after
a bpp or refresh specifier, combined with an option, e.g.
video=HDMI-1:720x480-24e,rotate=180 would not work, either the "e" to
force enable would need to be dropped or the ",rotate=180", otherwise
the mode_option would not be accepted.

This commit fixes this by fixing the length calculation if extras_ptr
is set to stop the extra parsing at the start of the options (stop at the
',' options_ptr points to).

Acked-by: Maxime Ripard <mripard@kernel.org>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20191118155134.30468-3-hdegoede@redhat.com
drivers/gpu/drm/drm_modes.c
drivers/gpu/drm/selftests/drm_cmdline_selftests.h
drivers/gpu/drm/selftests/test-drm_cmdline_parser.c